Skip to content

fix(amazonq): ensure plan opens for min JDK upgrades #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2025
Merged

fix(amazonq): ensure plan opens for min JDK upgrades #6000

merged 3 commits into from
Aug 27, 2025

Conversation

dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Aug 26, 2025 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Transformation plan was not opening for min JDK upgrades due to isPlanComplete method bug: if doing a JDK upgrade, as soon as plan is non-null, plan is complete, so open it.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested a review from a team as a code owner August 26, 2025 20:21
@rli rli merged commit 4e6c759 into aws:main Aug 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rli rli rli approved these changes

@ntarakad-aws ntarakad-aws ntarakad-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhasani23 @rli @ntarakad-aws